Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preload_module_classes is lost in attach_execution_device_hook. #3060

Open
4 tasks
wejoncy opened this issue Aug 29, 2024 · 8 comments · May be fixed by #3248
Open
4 tasks

preload_module_classes is lost in attach_execution_device_hook. #3060

wejoncy opened this issue Aug 29, 2024 · 8 comments · May be fixed by #3248
Assignees
@SunMarc

Comments

@wejoncy
Copy link

wejoncy commented Aug 29, 2024 •
edited
Loading

System Info

accelerate/src/accelerate/hooks.py

Line 439 in 3fcc946

attach_execution_device_hook(child, execution_device, tied_params_map=tied_params_map)

Should we pass preload_module_classes to the next calling? such as

        attach_execution_device_hook(child, execution_device, tied_params_map=tied_params_map, 
 preload_module_classes=preload_module_classes)

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
  • My own task or dataset (give details below)

Reproduction

Step into the code is enough.

Expected behavior

Identify the bug.
@wejoncy
Copy link
Author

wejoncy commented Sep 2, 2024 •
edited
Loading

Hi @muellerzr
Could you please take a look at it? Sorry if I ping the wrong contributor could you please help to recommend someone? Thanks

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@wejoncy
Copy link
Author

wejoncy commented Sep 29, 2024

Could anyone help to look at this issue？

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@wejoncy
Copy link
Author

wejoncy commented Oct 28, 2024

Hi @SunMarc

Could you please take a look at this issue when you get a time?
Thanks.

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@SunMarc
Copy link
Member

SunMarc commented Nov 21, 2024

Oh my bad sorry for the delay @wejoncy, I totally missed it. We indeed need to pass it. Could you open a PR to fix it ?

@wejoncy wejoncy linked a pull request Nov 22, 2024 that will close this issue
Open
@wejoncy
Copy link
Author

wejoncy commented Nov 22, 2024

Sure.
I opened a PR to resolve this.
#3248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SunMarc SunMarc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Resolve #3060, preload_module_classes is lost for nested modules wejoncy/accelerate
2 participants
@wejoncy @SunMarc