Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.6.0 refactoring issue with 'use_fp16' #286

Closed
Nomiizz opened this issue Mar 18, 2022 · 2 comments
Closed

v0.6.0 refactoring issue with 'use_fp16' #286

Nomiizz opened this issue Mar 18, 2022 · 2 comments

Comments

@Nomiizz
Copy link

Nomiizz commented Mar 18, 2022

On line 481 of accelerator.py, self.state.use_fp16 is being used whereas use_fp16 has been renamed to mixed_precision. This is causing the code to break. This check should probably be replaced with a call to the property method at line 234.
@sgugger
Copy link
Collaborator

sgugger commented Mar 18, 2022

Very good point, will fix and issue a patch!

@sgugger
Copy link
Collaborator

sgugger commented Mar 18, 2022

Should be fixed by this commit.

@sgugger sgugger closed this as completed Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nomiizz @sgugger