fix websocket ping variables issues #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter settings did not take effect
|
@brooklet Can you take a look at the failing tests? |
ahopkins
requested changes
Aug 16, 2020
sanic/server.py
Outdated
| @@ -955,14 +955,14 @@ def serve( | |||
| def _build_protocol_kwargs( | |||
| protocol: Type[HttpProtocol], config: Config | |||
| ) -> dict: | |||
| if hasattr(protocol, "websocket_timeout"): | |||
| if (dir(protocol).__contains__("websocket_handshake")): | |||
There was a problem hiding this comment.
Why are you checking for properties this way? Please avoid using dir() here.
There was a problem hiding this comment.
reverted to hasattr, but I might circle back on this to see why we are not using isinstance here, which seems more logical. Do we need duck typing for some reason I am unaware of?
| "ping_timeout": config.WEBSOCKET_PING_TIMEOUT, | ||
| "ping_interval": config.WEBSOCKET_PING_INTERVAL, | ||
| "websocket_max_size": config.WEBSOCKET_MAX_SIZE, | ||
| "websocket_max_queue": config.WEBSOCKET_MAX_QUEUE, |
There was a problem hiding this comment.
Why are these being renamed websocket_?
There was a problem hiding this comment.
Left this change in, but I updated the tests so that the change was carried through consistently.
|
@brooklet we want to try to get this merged before the Sanic 2020-09 release. Are you able to make those changes suggested? |
ahopkins
approved these changes
Sep 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the problem that the websocket ping_timeout and ping_interval parameter settings did not take effect