Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with new logo, change Congfig.LOGO, run linter #1443

Merged
merged 5 commits into from
Dec 30, 2018

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Dec 30, 2018

The main purpose of this was to add the new logo and update contents of README.

However, it also addressed the issue with #1432 and #1441. In running the test suite, it became apparent that there was some formatting changes needed from black and isort.

@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #1443 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   91.32%   91.32%   +<.01%     
==========================================
  Files          17       17              
  Lines        1717     1718       +1     
  Branches      322      322              
==========================================
+ Hits         1568     1569       +1     
  Misses        123      123              
  Partials       26       26
Impacted Files Coverage Δ
sanic/app.py 91.46% <100%> (+0.24%) ⬆️
sanic/config.py 100% <100%> (ø) ⬆️
sanic/router.py 95.43% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f2e18...94e8568. Read the comment docs.

Add new logo and update contents of README.

Update README.rst

Fix image syntax.

Update README.rst

Fix README links.
@ahopkins ahopkins changed the title Update README.rst Update README with new logo Dec 30, 2018
Update logo text

Reformat app.py
@ahopkins ahopkins changed the title Update README with new logo Update README with new logo, change Congfig.LOGO Dec 30, 2018
@ahopkins ahopkins changed the title Update README with new logo, change Congfig.LOGO Update README with new logo, change Congfig.LOGO, run linter Dec 30, 2018
@yunstanford yunstanford merged commit ff38a3c into master Dec 30, 2018
@ahopkins ahopkins deleted the new-readme branch December 30, 2018 21:31
@ahopkins ahopkins removed the request for review from sjsadowski December 30, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants