Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to exit with error for missing dependencies #9

Open
atharvai opened this issue Sep 16, 2016 · 1 comment
Open

Add toggle to exit with error for missing dependencies #9

atharvai opened this issue Sep 16, 2016 · 1 comment

Comments

@atharvai
Copy link
Contributor

atharvai commented Sep 16, 2016

Currently only Failed tasks results in luigi-monitor exiting with failed status code, This is a proposal to make luigi-monitor return a fail status code when there are missing dependencies. This can indicate some errors or undesired state.

Default behaviour should be the current behaviour and passing in toggle like
monitor(slack=SLACK_URL, fail_on_missing=True)
fail_on_missing is False by default.

@atharvai
Copy link
Contributor Author

I spent some time on this today, but it looks like there isn't an easy or good way to capture the return status of luigi.run() from within the context manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant