Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests ensuring minimum eslint peer dependency version is compatible with our rules #22

Open
lshearer opened this issue Feb 9, 2016 · 0 comments

Comments

@lshearer
Copy link

lshearer commented Feb 9, 2016

We specify eslint as a peer dependency of eslint-config-hudl, but there are a few issues:

  • The version in peerDependencies differs from that in devDependencies, so the version tests are run with does not fall in the same version range.
  • There is no maximum version currently on the peer dependency
  • The dev dependency uses ^, so it will install the latest compatible. We should be testing against the earliest.

Solution:

  • Change the peer dependency to have a max value (or use ^ form)
  • Set the dev dependency to be exactly equal to the minimum version satisfying the peer dependency
  • Add tests to ensure these values stay in sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant