Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's convert the script from CoffeeScript to JavaScript #216

Closed
KeesCBakker opened this issue Aug 28, 2023 · 6 comments
Closed

Let's convert the script from CoffeeScript to JavaScript #216

KeesCBakker opened this issue Aug 28, 2023 · 6 comments

Comments

@KeesCBakker
Copy link
Contributor

Hi, I would love to contribute to the script, but coffee is something I drink, not code. Can we convert the code to JavaScript?

@stephenyeargin
Copy link
Member

stephenyeargin commented Aug 29, 2023

I think that would be a good move, particularly with the plan to drop CoffeeScript support. This one, like hubot-grafana, is a fairly important one for incident response, so lets tread carefully. It also has a pattern where parts of it are abstracted away from the responders, so it may be easier to test in isolation compared to it all being in a single file.

@KeesCBakker
Copy link
Contributor Author

This this project might benefit from some API mock testing as well, but they are currently not in place.

@KeesCBakker
Copy link
Contributor Author

Any plans on releasing?

@stephenyeargin
Copy link
Member

Done.

https://github.com/hubot-archive/hubot-pager-me/releases/tag/v4.0.0

I really need to get some of these wired up with a GitHub action that will do it for me rather than running it from my own command line.

@joeyguerra
Copy link

joeyguerra commented Nov 5, 2023

@stephenyeargin Hubot uses semantic-release for it's releases

@stephenyeargin
Copy link
Member

Fixed by #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants