Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEX dataset, vitessce error #2345

Closed
mccalluc opened this issue Jan 11, 2022 · 3 comments · Fixed by #2432
Closed

CODEX dataset, vitessce error #2345

mccalluc opened this issue Jan 11, 2022 · 3 comments · Fixed by #2432
Assignees
Labels
bug Something isn't working feature: vitessce View configs / pipelines

Comments

@mccalluc
Copy link
Contributor

mccalluc commented Jan 11, 2022

https://portal.hubmapconsortium.org/browse/dataset/35ea0ff39fc1bd6846df15860dead4d3

(requires login)

on FF, in an error box in Vitessce:

i is undefined

on Chrome:

Cannot read properties of undefined (reading 'offset')

Looking in the console doesn't help much.

@mccalluc mccalluc added the bug Something isn't working label Jan 11, 2022
@ilan-gold
Copy link
Member

geotiffjs/geotiff.js#193 has resurfaced because it was not re-implemented when the new fetching mechanism was implemented: geotiffjs/geotiff.js#94

We run on a fork of geotiff so I can fix this myself.

@ilan-gold
Copy link
Member

ilan-gold commented Jan 11, 2022

To reproduce the issue where a fetch is made out of range (which is the issue as linked):

  1. Download the mask from this dataset and start a local file server to serve the file to Avivator
  2. Look at the network requests
  3. Notice the 416 error - the actual file only has 25,623,971 bytes but the requests is seeking more than that

Screen Shot 2022-01-11 at 6 57 39 PM

@mccalluc
Copy link
Contributor Author

mccalluc commented Jan 20, 2022

Underlying fix has been made in viv... Ilan will get that into vitessce ... and then get that into portal.

@mccalluc mccalluc linked a pull request Feb 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: vitessce View configs / pipelines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants