-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specific markers on general classes #16
Comments
Here's a complete list of cell types with markers and their locations. https://yasgui.triply.cc/# As Josef noticed in #8, a few cell types share the same marker in a different location, or a few don't have a marker in specific locations. I'll create a report listing all cell types in specific locations and markers; then, I can make a template to add them to CL. |
Generic Yasgui link. #8 is basically the same issue. |
Ops, here's again https://api.triplydb.com/s/jJ4B6VyBt |
Some thoughts:
Suggested decision tree: Does cell have a markers? -Y -> Does it have subclasses? - Y -> *AS = most specific AS |
Thanks @anitacaron! I had not realized this moved forward about the markers connected to cell types. |
I've removed the Blood Vasculature from the merged report, which I'm using as input to generate the ROBOT template. This reduces a lot the size of the templates. I'm aware of the duplications in the templates. Here's the first draft of the ROBOT template for CCF https://github.com/hubmapconsortium/ccf-validation-tools/blob/2bf64dee8ea0246137db16c2128240d1908c88fb/templates/ccf_compound.tsv |
@emquardokus I looked carefully into the template to bulk-create the compound CL terms and found different markers for the same cell type and location. The case I found is in the Skin and Large intestine tables. I'll try to find other instances. Is this intended? On the Skin table (row 25):
On the Large intestine (row 1324):
|
Specific markers are linked to very general cell classes, e.g. these are recorded as generic markers of epithelial cells
Checking out the CCF relationships indicated these are for epithelial cells of the iris epithelium:
As a result, any query for cells expressing AQP1, will find all epithelial cells - although that was clearly not the expert's intent. This will be true with a standard OWL query, but queries using CCF properties would suffer from the same issue unless we generate separate graphs for each table and don't allow for cross-table queries.
Here's another example that shows up an additional problem:
The same generic cell type is linked to two locations but has only one marker set - presumably coming from one location (not sure which). But as there's only one cell type term (IRI), the markers are associated with both locations.
The obvious fix is to make location specific terms for each of these using a standard ROBOT template and add these to CL.
e.g. iris epithelial cell
The text was updated successfully, but these errors were encountered: