Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mccalluc/lint #23

Closed
wants to merge 7 commits into from
Closed

Mccalluc/lint #23

wants to merge 7 commits into from

Conversation

mccalluc
Copy link
Contributor

Linting the code on check in is an easy way to catch some simple bugs, and avoid code style arguments.

Fix #21

@mccalluc mccalluc requested a review from pdblood January 21, 2020 00:53
pdblood
pdblood reviewed Jan 22, 2020
View reviewed changes
Copy link
Member

@pdblood pdblood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good idea, although I think I'd rather apply this change immediately after our demo on Friday.

@mccalluc
Copy link
Contributor Author

mccalluc commented Feb 5, 2020

@pdblood : If you want me to handle merge conflicts, I can.

@mccalluc
Copy link
Contributor Author

Still think linting is a good thing, but it would be easier to do from scratch. Closing.

@mccalluc mccalluc closed this Apr 24, 2020
@mccalluc mccalluc deleted the mccalluc/lint branch April 24, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdblood pdblood pdblood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint the DAGs
2 participants
@mccalluc @pdblood