-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List team members by role #950
Conversation
ca7c568
to
1c07742
Compare
public PagedIterable<GHUser> listMembers() throws IOException { | ||
return root.createRequest().withUrlPath(api("/members")).toIterable(GHUser[].class, item -> item.wrapUp(root)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an API change. Please retain the existing public method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have readded the original public method.
* @throws IOException | ||
* the io exception | ||
*/ | ||
public PagedIterable<GHUser> listMembersWithRole(String role) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public PagedIterable<GHUser> listMembersWithRole(String role) throws IOException { | |
public PagedIterable<GHUser> listMembers(String role) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have renamed the method.
1c07742
to
7b900e2
Compare
7b900e2
to
86f64e8
Compare
86f64e8
to
a800c19
Compare
a800c19
to
9d161b2
Compare
Description
Upgrades the listing method to also take a role.
Closes #926.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master
. Create your PR from that branch.mvn clean compile
locally. This may reformat your code, commit those changes.mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.When creating a PR: