Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish moving all full URL setting to setRawUrlPath and change withUrlPath to not require starting / #700

Open
bitwiseman opened this issue Feb 17, 2020 · 0 comments
Labels

Comments

@bitwiseman
Copy link
Member

bitwiseman commented Feb 17, 2020

#697 (comment)

This will require looking at each call to withUrlPath to determine if it is passing a tail URL (starting with "/") or passing a full url (starting with http).

Oh, look here's one:
https://github.com/github-api/github-api/blob/ff3136df7069d22d937daa8f2cddc357c777e07e/src/main/java/org/kohsuke/github/GHBranch.java#L104

There more in that class as well, but there are no tests for a number of those methods.

So, each case of this needs a test written to show it works and then change to use setRawUrlPath. Finally, when we should block withUrlPath from accepting full urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant