Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can only set PR milestone through instance of GHIssue, not GHPullRequest #416

Closed
gdgib opened this issue Feb 17, 2018 · 1 comment · Fixed by #899
Closed

Can only set PR milestone through instance of GHIssue, not GHPullRequest #416

gdgib opened this issue Feb 17, 2018 · 1 comment · Fixed by #899
Labels
bug

Comments

@gdgib
Copy link

gdgib commented Feb 17, 2018

GHPullRequest.setMilestone() which was helpfully added in #397 appears to have a minor bug. It works when called on an instance of GHIssue directly but not on GHPullRequest. I think this is because it calls edit rather than editIssue which is used by labels, assignees, etc and so it gets the wrong API endpoint for setting a milestone which is a property of the issue not the pull request.

I would submit a fix for this myself, except: #415. Sorry!
@gdgib
Copy link
Author

gdgib commented Aug 30, 2018

Now that #415 is solved (thanks @kohsuke for the excellent help!), I'll fix this myself and open a PR ASAP.

@gastaldi gastaldi mentioned this issue Jul 25, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PullRequest.setMilestone should use the Issue API gastaldi/github-api
2 participants
@gdgib @bitwiseman