Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate promoted preview API calls #1143

Closed
gadams00 opened this issue May 19, 2021 · 2 comments · Fixed by #1859
Closed

Undeprecate promoted preview API calls #1143

gadams00 opened this issue May 19, 2021 · 2 comments · Fixed by #1859

Comments

@gadams00
Copy link

https://developer.github.com/changes/2020-08-20-graduate-machine-man-and-sailor-v-previews/
https://github.com/hub4j/github-api/blob/main/src/main/java/org/kohsuke/github/internal/Previews.java#L90 Previews.MACHINE_MAN deprecations (and preview annotations) should no longer be necessary.

@bitwiseman
Copy link
Member

@gadams00 We should definitely remove @Deprecated. We plan to do that everywhere, see #1003 .
However, we don't want to remove the Preview yet, because we still need to support older versions of GitHub Enterprise where the endpoint is still in preview.

@bitwiseman
Copy link
Member

See https://github.blog/changelog/2021-10-14-rest-api-preview-promotions/

All but two previews have graduated.

@bitwiseman bitwiseman changed the title Undeprecate machine-man preview API calls Undeprecate promoted preview API calls Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants