Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all usages of HttpConnector and HttpURLConnection #1085

Closed
bitwiseman opened this issue Apr 9, 2021 · 1 comment · Fixed by #1314
Closed

Deprecate all usages of HttpConnector and HttpURLConnection #1085

bitwiseman opened this issue Apr 9, 2021 · 1 comment · Fixed by #1314

Comments

@bitwiseman
Copy link
Member

HttpConnector depends on HttpURLConnection an old and very crufty way of working with Http connections. Some modern clients have even stopped supporting HttpURLConnection. This makes it harder to implement support for different http clients.

We should remove all dependency on HttpConnector. GithubClient will become the new base class to extend in order to support new clients. Other methods the depend on HttpURLConnection should switch to other ways of providing the same information.

@bitwiseman
Copy link
Member Author

The implementation details changed but this task is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant