Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of Response::body*()'s MIME types. #378

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Fix documentation of Response::body*()'s MIME types. #378

merged 1 commit into from
Dec 24, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Dec 21, 2019

  1. The MIME of Response::body() was wrongly documented as text/plain; charset=utf-8 (copy-and-paste error). It should be application/octet-stream.
  2. Also documented the MIME types of Response::body_form() and Response::body_json().

yoshuawuyts
yoshuawuyts approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps; this is great!

@yoshuawuyts yoshuawuyts merged commit ee017f2 into http-rs:master Dec 24, 2019
@kennytm kennytm deleted the correct-body-mime branch December 24, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennytm @yoshuawuyts