No body content for StatusCode::InternalServerError

[nwilcox93]

tide/src/server.rs

Line 416 in 293610b

if !res.status().is_server_error() {

When returning an Err(http_types::Error) inside a handler that returns a tide::Result, the message for the error is not displayed in the browser if the status is StatusCode::InternalServerError. I can work around this by returning Ok(Response) with StatusCode::InternalServerError. It seems like it is an anti-pattern to return Ok(Response) when an error occurred on the server. Just looking for some clarification the correct approach.

Thanks!

[jbr]

See #570 for some changes related to this. In short, error handling is likely changing substantially in the near future

[jbr]

The solution for this in tide >= 0.12 is to add a middleware that catches responses with an attached error and builds a string body with it, something like:

    app.middleware(After(|mut res: Response| async {
        if let Some(err) = res.take_error() {
            res.set_body(err.to_string()) // or json, or html, etc, whatever is appropriate for your app
        }
        Ok(res)
    }));