Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokio dependencies #427

Closed
gmosx opened this issue Mar 31, 2020 · 3 comments
Closed

Tokio dependencies #427

gmosx opened this issue Mar 31, 2020 · 3 comments

Comments

@gmosx
Copy link

gmosx commented Mar 31, 2020

I tried to build the simple 'hello-world' example from the README. I see that multiple tokio dependencies are added, e.g.

...
 Compiling tokio-executor v0.1.10
 Compiling tokio-current-thread v0.1.7
 Compiling tokio-timer v0.2.13
 Compiling tokio-io v0.1.13
 Compiling tokio-threadpool v0.1.18
 Compiling tokio-reactor v0.1.12
 Compiling tokio-tcp v0.1.4
 Compiling tokio v0.1.22
...

Is this intentional?
@minioin
Copy link

minioin commented Apr 2, 2020

I think it's consequential, different dependencies pulling in different versions.

@yoshuawuyts
Copy link
Member

This should be resolved by #414; we haven't fully optimized our dependencies yet, and there are still some odd edge cases like these present.

@pickfire
Copy link
Contributor

pickfire commented Apr 3, 2020

Does not this increase the build time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gmosx @yoshuawuyts @pickfire @minioin