Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isn't RequestLogger ready to be used? #366

Closed
kenkoooo opened this issue Dec 12, 2019 · 2 comments · Fixed by #367
Closed

Isn't RequestLogger ready to be used? #366

kenkoooo opened this issue Dec 12, 2019 · 2 comments · Fixed by #367

Comments

@kenkoooo
Copy link
Contributor

kenkoooo commented Dec 12, 2019 •
edited
Loading

Currently, one of example middewares RequestLogger is disabled in v0.4.0, but I confirmed it can work on this version without any change. Is there any plan to enable it?
@yoshuawuyts
Copy link
Member

@kenkoooo oh yeah, we should probably enable it. Perhaps out of the box even. If you'd like to file a patch it'd be most welcome!

@kenkoooo
Copy link
Contributor Author

@yoshuawuyts Thanks! Let me work on it.

@kenkoooo kenkoooo mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable middleware::RequestLogger again kenkoooo/tide
2 participants
@yoshuawuyts @kenkoooo