Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't pull in wasm dependencies on non-wasm platforms #136

Open
joshtriplett opened this issue Aug 26, 2020 · 5 comments
Open

Please don't pull in wasm dependencies on non-wasm platforms #136

joshtriplett opened this issue Aug 26, 2020 · 5 comments

Comments

@joshtriplett
Copy link
Member

async-h1 depends on async-std with the unstable feature; that in turn pulls in wasm dependencies via futures-timer then gloo-timers. Please consider adjusting the feature flag dependencies to avoid pulling gloo-timers and its pile of wasm-specific dependencies on non-wasm platforms.

@jbr
Copy link
Member

jbr commented Aug 26, 2020

async-rs/async-std#823 — I believe this is a cargo bug. Proposed async-std solution here: async-rs/async-std#864. This also breaks no-std for async-std, as far as I can tell. I personally believe this issue is fairly important

@jbr
Copy link
Member

jbr commented Aug 26, 2020

Closing this issue because there's nothing we can do to resolve it here or in the other http-rs crates that have this problem, but please add your support to async-rs/async-std#823

@jbr jbr closed this as completed Aug 26, 2020
@joshtriplett
Copy link
Member Author

Does async-h1 need the "unstable" feature of async-std? Could it have a finer-grained dependency?

@jbr
Copy link
Member

jbr commented Aug 27, 2020

That's a great point. Async-h1 itself does not

@jbr
Copy link
Member

jbr commented Aug 27, 2020

Unfortunately, this does not really fix the problem — async-h1 depends on http-types, which uses async_std::sync::channel, which is gated behind unstable and async-std does not have a more granular set of features to enable: https://github.com/async-rs/async-std/blob/master/src/sync/channel.rs#L61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants