Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic of eof-in-comment error positions #125

Open
JKingweb opened this issue Dec 20, 2019 · 0 comments
Open

Logic of eof-in-comment error positions #125

JKingweb opened this issue Dec 20, 2019 · 0 comments

Comments

@JKingweb
Copy link

I'm finishing up testing of a tokenizer implementation, which I've tried to make pass the test suite in its entirety, including line and column positions for parse errors.

While supplementary-plane characters counting for two columns has some logic to it, I find myself struggling to understand the logic behind the positions in the tests added by @hsivonen:

https://github.com/html5lib/html5lib-tests/pull/121/files

Other EOF errors (and indeed, other eof-in-comment errors) use the position of the EOF itself, while these use a position one character behind. The position is also on line 1 rather than line 2 despite there being a line break just before.

Is this simply an oversight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant