Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneously removes > #37

Closed
remko opened this issue Jan 14, 2015 · 4 comments
Closed

Erroneously removes > #37

remko opened this issue Jan 14, 2015 · 4 comments

Comments

@remko
Copy link

remko commented Jan 14, 2015

html-to-text removes >, even if the < is escaped.

$ echo "&lt;b>Hello" | ./bin/cli.js 
<b Hello
@mlegenhausen
Copy link
Member

Why you do not escape both?

@dule
Copy link

dule commented Dec 7, 2015

But that's assuming the source text has escaped it. If we don't control where the input comes from, a string like <p> Good > Bad </p> will become Good Bad.

@dule
Copy link

dule commented Dec 7, 2015

Though I suppose this is actually a problem with tautologistics/node-htmlparser#72

@KillyMXI
Copy link
Member

html-to-text uses htmlparser2 currently.

This issue seem to be outdated. I can't reproduce it.

GitBash under Windows:

$ echo "&lt;b>Hello" | node.exe ./bin/cli.js
<b>Hello

pwsh under Windows:

PS> echo "&lt;b>Hello" | node ./bin/cli.js
<b>Hello
PS> echo "<p> Good > Bad </p>" | node ./bin/cli.js
Good > Bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants