Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css) use width instead of max-width for column sizes #99

Merged
merged 1 commit into from
Dec 28, 2016
Merged

fix(css) use width instead of max-width for column sizes #99

merged 1 commit into from
Dec 28, 2016

Conversation

kybishop
Copy link
Collaborator

Fixes #75

A couple small test fixes as well

@RobbieTheWagner
Copy link
Member

@runspired any reason we shouldn't go ahead and merge this?

@kybishop kybishop mentioned this pull request Dec 27, 2016
Merged
RobbieTheWagner
RobbieTheWagner approved these changes Dec 28, 2016
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobbieTheWagner RobbieTheWagner merged commit 2e6a065 into html-next:master Dec 28, 2016
@kybishop kybishop mentioned this pull request Jan 4, 2017
Open
@kybishop kybishop deleted the use-width-for-column-sizes-instead-of-max-width branch February 7, 2017 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using both an offset and column size causes unexpected width.
2 participants
@kybishop @RobbieTheWagner