Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulnerabilities related to storybook #74

Open
htbkoo opened this issue May 31, 2021 · 3 comments · Fixed by #83
Open

Fix vulnerabilities related to storybook #74

htbkoo opened this issue May 31, 2021 · 3 comments · Fixed by #83
Assignees
@htbkoo

Comments

@htbkoo
Copy link
Owner

htbkoo commented May 31, 2021

Related:

  1. Vulnerability on @storybook/addon-docs related with trim storybookjs/storybook#14603
@htbkoo htbkoo self-assigned this May 31, 2021
@htbkoo
Copy link
Owner Author

htbkoo commented Oct 29, 2021

As of 29-Oct-2021, merged #76 #77 #78 #79 #80 #81

@htbkoo
Copy link
Owner Author

htbkoo commented Oct 29, 2021

Unfortunately apparently not all warnings are relevant / need to be fixed.

See facebook/create-react-app#11174 for more details

Will close this once react is upgraded to the latest version which is 17.0.2 as of 29-Oct-2021

@htbkoo htbkoo mentioned this issue Oct 29, 2021
Merged
@htbkoo
Copy link
Owner Author

htbkoo commented Oct 29, 2021

Actually the storybook issue (storybookjs/storybook#14603) is not resolved yet, reopening this and will rename the issue title for clarity

@htbkoo htbkoo reopened this Oct 29, 2021
@htbkoo htbkoo changed the title Fix vulnerabilities (as of May-2021) Fix vulnerabilities related to storybook Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@htbkoo htbkoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade react to 17.0.2 htbkoo/personal-portfolio
1 participant
@htbkoo