Issue #594 - Parse XML element names beginning with Valid NameChar #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ablackton as commented in #594 this looks good... thanks... Will merge if someone else can test and confirm... thanks... |
|
Builds, tests, and works for me. Feel free to merge. Thanks, @ablackton! |
geoffmcl
added a commit
that referenced
this pull request
Sep 20, 2017
|
@ablackton, @balthisar, now merged... bumped to version 5.5.39, 2017.09.20... thanks... |
|
@geoffmcl and @balthisar, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for issue #594
Allow xml elements names to begin with valid non-letter name characters.
This is a superset of the xml standard's defined NameStartChars.
https://www.w3.org/TR/REC-xml/#NT-NameStartChar