Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Update of xml expected for test 1510101 #20

Open
geoffmcl opened this issue Sep 20, 2017 · 2 comments
Open

Update of xml expected for test 1510101 #20

geoffmcl opened this issue Sep 20, 2017 · 2 comments
Labels

Comments

@geoffmcl
Copy link
Contributor

Having just run the xml tests, the first time for quite a while, note there has been a change in the output for test xml/case-1510101.[xml/conf]...

Looking back, this test was added due to https://sourceforge.net/p/tidy/bugs/777/, which fixed a bug, and it seems this bug remains fixed, the purpose of the test...

It seems the only change in the pretty print output are just indent changes... this change could have been around for quite a time... did not exactly check the commit that causes it...

It is certainly unrelated to the current xml PR #595...

Thus, baring any objections, propose to update the xml-expects\case-1510101.html to current output...

Comments welcome... thanks...

@geoffmcl
Copy link
Contributor Author

Just for Windows users, I created a small batch file, in tools-cmd, t-xml.bat, to do this xml testing -

@setlocal
@REM set TY_TIDY_PATH=C:\MDOS\tidy5.exe
@set TY_TIDY_PATH=F:\Projects\tidy-html5\build\win64\Release\tidy.exe
@if NOT EXIST %TY_TIDY_PATH% goto NOEXE
@set TMPVER=temp-xml-next
@set TMPOUT=..\cases\%TMPVER%-results
%TY_TIDY_PATH% -v
@if EXIST %TMPOUT%\nul (
@echo NOTE: Will delete %TMPOUT%
)
@pause
@if EXIST %TMPOUT%\nul (
rd /s /q %TMPOUT%
)
call alltest -c xml -o %TMPVER%
@goto END
:NOEXE
@echo Can NOT locate %TY_TIDY_PATH%! *** FIX ME ***
:END

Note it uses my path to the current tidy EXE, and sets the output to temp-xml-next... the important point is to run alltest.bat adding the -c xml option... thanks...

@balthisar
Copy link
Member

@geoffmcl, these all look okay to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants