Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stats][boxplot] fix container props calculation #203

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

williaster
Copy link
Collaborator

🐛 Bug Fix

  • fixes the container calculation for <Boxplot /> in @vx/stats (it appeared broken for horizontal and vertical positions, rendering negative widths etc)
  • moves outliers to the bottom-most layer of the <Boxplot />

This is the container element (styled) afterward, for both orientations
boxplot-container-rects

🚀 Enhancements

  • adds class names to the outlier circles and boxplot box rect

cc @conglei

@conglei
Copy link

conglei commented Nov 21, 2017

Thanking for catching this issue! and fix look good!

@williaster
Copy link
Collaborator Author

Hmm builds seem to be stuck:

lerna info Installing external dependencies

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received```

Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hshoff hshoff merged commit 7737e08 into airbnb:master Nov 29, 2017
@hshoff hshoff added this to the v0.0.148 milestone Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants