Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip clang-tidy on doctest via -isystem again #73

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: skip clang-tidy on doctest via -isystem again #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
-DCMAKE_CXX_FLAGS="-fstack-protector-strong -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wcast-qual -Wformat=2 -Wundef -Werror=float-equal -Wshadow=compatible-local -Wcast-align -Wunused -Wnull-dereference -Wdouble-promotion -Wimplicit-fallthrough -Wextra-semi -Woverloaded-virtual -Wnon-virtual-dtor -Wold-style-cast"
-DCMAKE_EXE_LINKER_FLAGS="-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now"
-DCMAKE_SHARED_LINKER_FLAGS="-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now"
-DCMAKE_CXX_CLANG_TIDY="clang-tidy;--header-filter=^/home/runner/work/monkey/monkey"
-DCMAKE_CXX_CLANG_TIDY="clang-tidy;--header-filter=^/home/runner/work/monkey/monkey/source"
-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON
-DCMAKE_CXX_CPPCHECK="cppcheck;--inline-suppr;--library=/home/runner/work/monkey/monkey/cppcheck/monkey.cfg"
-DCMAKE_CXX_EXTENSIONS=OFF
Expand Down
7 changes: 3 additions & 4 deletions test/doctest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
add_library(doctest INTERFACE)
add_library(doctest::doctest ALIAS doctest)
target_include_directories(doctest INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})

# HACK(hrzgnm): disable clang-tidy checks on doctest
target_include_directories(doctest SYSTEM INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})

add_library(doctest_dll dll.cpp)
add_library(doctest::dll ALIAS doctest_dll)
Expand All @@ -18,11 +20,8 @@ add_test(NAME doctest COMMAND $<TARGET_FILE:doctest_exe> --no-version)

# HACK(hrzgnm): disable analyzer checks on doctest targets
set_target_properties(doctest_exe PROPERTIES
CXX_CLANG_TIDY ""
CXX_CPPCHECK "")
set_target_properties(doctest_dll PROPERTIES
CXX_CLANG_TIDY ""
CXX_CPPCHECK "")
set_target_properties(doctest PROPERTIES
CXX_CLANG_TIDY ""
CXX_CPPCHECK "")