Skip to content

Commit

Permalink
chore: skip clang-tidy on doctest via -isystem again (#73)
Browse files Browse the repository at this point in the history
  • Loading branch information
hrzlgnm authored Nov 9, 2023
1 parent 9ba2c81 commit c0ed2ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
-DCMAKE_CXX_FLAGS="-fstack-protector-strong -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wcast-qual -Wformat=2 -Wundef -Werror=float-equal -Wshadow=compatible-local -Wcast-align -Wunused -Wnull-dereference -Wdouble-promotion -Wimplicit-fallthrough -Wextra-semi -Woverloaded-virtual -Wnon-virtual-dtor -Wold-style-cast"
-DCMAKE_EXE_LINKER_FLAGS="-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now"
-DCMAKE_SHARED_LINKER_FLAGS="-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now"
-DCMAKE_CXX_CLANG_TIDY="clang-tidy;--header-filter=^/home/runner/work/monkey/monkey"
-DCMAKE_CXX_CLANG_TIDY="clang-tidy;--header-filter=^/home/runner/work/monkey/monkey/source"
-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON
-DCMAKE_CXX_CPPCHECK="cppcheck;--inline-suppr;--library=/home/runner/work/monkey/monkey/cppcheck/monkey.cfg"
-DCMAKE_CXX_EXTENSIONS=OFF
Expand Down
7 changes: 3 additions & 4 deletions test/doctest/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
add_library(doctest INTERFACE)
add_library(doctest::doctest ALIAS doctest)
target_include_directories(doctest INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})

# HACK(hrzgnm): disable clang-tidy checks on doctest
target_include_directories(doctest SYSTEM INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})

add_library(doctest_dll dll.cpp)
add_library(doctest::dll ALIAS doctest_dll)
Expand All @@ -18,11 +20,8 @@ add_test(NAME doctest COMMAND $<TARGET_FILE:doctest_exe> --no-version)

# HACK(hrzgnm): disable analyzer checks on doctest targets
set_target_properties(doctest_exe PROPERTIES
CXX_CLANG_TIDY ""
CXX_CPPCHECK "")
set_target_properties(doctest_dll PROPERTIES
CXX_CLANG_TIDY ""
CXX_CPPCHECK "")
set_target_properties(doctest PROPERTIES
CXX_CLANG_TIDY ""
CXX_CPPCHECK "")

0 comments on commit c0ed2ce

Please sign in to comment.