Brave Story crashed in boss fight

[daniel229]

Since #8240 ,fixed in #8246

master build crash and color is wrong

with #8246 ,color is correct.

Stack trace

[asbel123]

i got no problem on my samsung galaxy s6 edge i use disable slow effects to speed this game crazy i finsh the game on the latest version no crashes on my phone.

[asbel123]

maybe its windows problem

[daniel229]

Right, disabling slow effects won't be affected.

[unknownbrackets]

Strange that the CLUT change would make splines crash. Maybe gpu->PerformMemoryDownload(clutAddr, bytes); is somehow downloading too much (like the whole framebuf when sequential transfers are detected?)

In that case maybe we need another API; #8246 makes it do that less often but it doesn't make it impossible. Specifically, if you use texture scaling it will still do it the old way.

If you remove this code in Framebuffer.cpp, does the problem go away?

            const static int FREQUENT_SEQUENTIAL_COPIES = 3;
            static int frameLastCopy = 0;
            static u32 bufferLastCopy = 0;
            static int copiesThisFrame = 0;
            if (frameLastCopy != gpuStats.numFlips || bufferLastCopy != vfb->fb_address) {
                frameLastCopy = gpuStats.numFlips;
                bufferLastCopy = vfb->fb_address;
                copiesThisFrame = 0;
            }
            if (++copiesThisFrame > FREQUENT_SEQUENTIAL_COPIES) {
                gameUsesSequentialCopies_ = true;
            }

I realize the color might still be wrong, but I'm more concerned about the crash. Also, can you upload a save or savestate?

-[Unknown]

[daniel229]

save and the savestate
https://drive.google.com/folderview?id=0BzGZGDfFE68zM09hc2dKc1BSZkE&usp=sharing

[daniel229]

It's helped by removing that code. Also the color become right.