Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI: Rendering Resolution option partially broken since v0.9.6-877-g8a2b50a #5401

Closed
thedax opened this issue Feb 11, 2014 · 3 comments
Closed

Comments

@thedax
Copy link
Collaborator

thedax commented Feb 11, 2014

The aftermath of the scaling cleanup continues. By partially broken, I mean the Rendering Resolution option under Game Settings does literally nothing until the window is resized (or the Window Size option is used to pick a size that's different from the current one), or the user goes fullscreen/exits it back to windowed mode.

Responsible commit is 8a2b50a. Last working build is ca9d0ea.

Not that it's really needed, but, steps to reproduce:

  1. Open PPSSPP.
  2. Start a game.
  3. Change the rendering resolution to something different.
  4. Observe that nothing visibly changes (easiest to see in 3d games), unlike previous builds.
  5. Resize the window, or use Game Settings -> Window Size to change it to something different.
  6. The game upscales or downscales appropriately.
@solarmystic
Copy link
Contributor

Confirmed and verified. Using the Ctrl-1 shortcut in any game is the easiest way to reproduce this issue. Start off with Auto, and then spam the shortcut repeatedly. No changes to the rendering resolution can be observed.

This really only affects the ability of the desktop builds to observe those rendering resolution changes in realtime. Mobile builds do it by exiting to the NewUI to do it each time, and doing it that way still works properly.

@hrydgard
Copy link
Owner

Thank you, sorry about this. I will fix it up tonight.

I had to do the sizing in a cleaner way to be able to introduce various fun features later like stereo rendering, and introduced some bugs in the process apparently.

@thedax
Copy link
Collaborator Author

thedax commented Feb 12, 2014

That fixed it, thanks.

hrydgard added a commit that referenced this issue Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants