Toggled Speed Limit uses the internal speed since v0.8.1-1159

[ShadowLady]

Commit bc00a7e about frameskipping causes the Toggled Speed Limit to use the internal FPS of the game instead of the the full speed.

Makes it more difficult to keep a consistent toggled speed between games. For example for 2x speed on MGS Peace Walker I'd have to set it to 40FPS (game's internal speed is 20FPS), while this same toggled speed on a 60fps game like Tomb Raider Aniversary would actually be a slowdown.
Before this commit you could have the toggled speed set to a specific amount for all games since they all used full speed for the toggled limit.

As an aside note maybe the toggled speed limit could be done so you can choose a specific percentage from it, like I'd assume popular 50% and 200% speed toggles

Edit: Oh I never use frameskipping so it shouldnt be related to that btw.

Edit: Just as another note, Fraps which usually matched the internal speed of the games now seems to show different ones... like the videos on dongan ronpa used to show 30fps, not shows as 40fps on fraps (still 30fps internal tho)

[solarmystic]

@ShadowLady

Confirmed. Here's a very simple test showing the issue in a very recent build.

1. Set the Toggled Speed Limit to 120
   
2. Run a few games with different Internal FPS. For this example I shall be using Danganronpa, which uses 30 FPS internally. Multithreaded is OFF to prevent bias.
3. Hit the Toggle Speed Limit hotkey.
4. Notice that Danganronpa does not run at 120 VPS after the hotkey is pressed, it runs at double the amount now (240 VPS)
   
5. This phenomenon is reproducible on a lot of different games.

[solarmystic]

However, in a 60 FPS game, the Speed is accelerated accordingly to 120 VPS when the toggled speed limit hotkey is pressed. E.g. Final Fantasy I

[ShadowLady]

Yep exactly, and this on peace walker (20fps internal) with same test:

[hrydgard]

Thanks guys for finding this issue, this isn't ideal for sure. will see if I can find an easy fix before 0.9.

[bonquacks]

Issue has been resolved for me with v0.8.1-1622-g0265ab8 0265ab8

If @ShadowLady can corroborate this finding, we can close this issue.

[hrydgard]

I've tested it myself enough I think, I'll just close :)