Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release all keys on pause. #18786

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Release all keys on pause. #18786

merged 1 commit into from
Jan 29, 2024

Conversation

hrydgard
Copy link
Owner

Fixes #18767

Not sure about merging for the 1.17 series though, maybe someone really likes to bring up the pause menu briefly while holding a direction.. we could actually handle that with some extra logic.

Fixes #18767

Not sure about merging for the 1.17 series though, maybe someone really
likes to bring up the pause menu briefly while holding a direction.. we
could actually handle that with some extra logic.
@hrydgard hrydgard added the Input/Controller Input and controller issues label Jan 29, 2024
@hrydgard hrydgard added this to the v1.18.0 milestone Jan 29, 2024
@hrydgard hrydgard merged commit cf1fd71 into master Jan 29, 2024
18 checks passed
@hrydgard hrydgard deleted the release-inputs-on-pause branch January 29, 2024 18:21
@hrydgard
Copy link
Owner Author

Argh didn't mean to click merge here, wrong window. still. whatever. it might be fine :)

@LunaMoo
Copy link
Collaborator

LunaMoo commented Feb 25, 2024

I recall using keys lock on pause as feature to create some cheats easier in the past(to ensure required inputs are ON while searching) or using it to lock a key that I otherwise had to press all the time, but that's just me being lazy, same things can be done with external makros or just holding the buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When bringing up the pause menu (with run-behind), inputs may stay pressed
2 participants