Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: HiDPI support on Wayland (blurry fonts) #17650

Closed
5 tasks done
hch12907 opened this issue Jun 30, 2023 · 4 comments
Closed
5 tasks done

SDL: HiDPI support on Wayland (blurry fonts) #17650

hch12907 opened this issue Jun 30, 2023 · 4 comments
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports.
Milestone

Comments

@hch12907
Copy link
Contributor

hch12907 commented Jun 30, 2023

Game or games this happens in

None

What area of the game / PPSSPP

When I am using PPSSPP on Wayland with HiDPI scaling, there is a general blurriness on everything in the main menu,.

I have a hacky build (with hardcoded DPI and stuff...) that showcases how it should look like compared to the latest stable build:

image

image

What should happen

The text should look sharp.

Logs

No response

Platform

Linux / BSD

Mobile phone model or graphics card

It's irrelevant, but AMD Renoir iGPU

PPSSPP version affected

42d4b5d

Last working version

No response

Graphics backend (3D API)

Other

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@hch12907
Copy link
Contributor Author

I have a commit for this in ba3203d.

For some reason the compiler chokes on SDL_Vulkan_GetDrawableSize() in SDLMain.cpp though...

@hch12907 hch12907 closed this as completed Jul 3, 2023
@hrydgard
Copy link
Owner

hrydgard commented Jul 3, 2023

Ah, hm. Do feel free to make a pull request for it anyway, and let's use CI to figure out what platforms have trouble..

@hrydgard hrydgard added this to the v1.16.0 milestone Jul 3, 2023
@hrydgard hrydgard added the SDL2 Issue on SDL (or Qt in SDL code) but not all ports. label Jul 3, 2023
@hch12907
Copy link
Contributor Author

hch12907 commented Jul 4, 2023

I closed this because HiDPI support on Wayland was added in #17651. Ingame graphics look crisp now as expected (before the PR, everything looked blurry on SDL Wayland, even in-game), but the text in main menu still looked somewhat soft:

image

Interestingly, the borders of each UI element (buttons etc) look pretty sharp. The only thing that remains to be fixed on HiDPI is text rendering.

@hrydgard
Copy link
Owner

hrydgard commented Aug 1, 2023

The text rendering sharpness issue should be fixed now with #17780 .

Some of our bitmap symbols and icons could also use higher-definition versions I suppose, but that's kind of a big project.

@hrydgard hrydgard closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports.
Projects
None yet
Development

No branches or pull requests

3 participants