Debugger: Avoid unaligned reads in expressions #17269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
requested changes
Apr 12, 2023
| @@ -396,7 +396,7 @@ u32 DisassemblyManager::getNthNextAddress(u32 address, int n) | |||
| analyze(address); | |||
There was a problem hiding this comment.
should we avoid analyzing if the address has gotten unaligned? It feels like there are some early checks possible, rather than just aligning the return value?
There was a problem hiding this comment.
Well, that actually aligns the address, and I didn't want to change that logic.
-[Unknown]
Core/MIPS/MIPSDebugInterface.cpp
Outdated
|
|
||
| switch (size) { | ||
| case 1: | ||
| dest = valid ? Memory::Read_U8(address) : 0; | ||
| dest = (buf[3] << 24) | (buf[2] << 16) | (buf[1] << 8) | buf[0]; |
There was a problem hiding this comment.
Hm, how does this do the same as the old code? previously it returned maximum an 8-bit value. I think this case is swapped with "case 4".
There was a problem hiding this comment.
Oops, thanks. I guess I only tried something where the lowest byte mattered anyway...
-[Unknown]
GPU/Common/GPUDebugInterface.cpp
Outdated
|
|
||
| switch (size) { | ||
| case 1: | ||
| dest = valid ? Memory::Read_U8(address) : 0; | ||
| dest = (buf[3] << 24) | (buf[2] << 16) | (buf[1] << 8) | buf[0]; |
Potentially, a watch or break condition could crash if it was unaligned between mirrors. This might happen if it's not the condition you wanted, especially. Play it safe.
We ended up with an unaligned start address for our window.
unknownbrackets
force-pushed
the
debugger-minor
branch
from
10ed99a to
6998b18
Compare
hrydgard
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent crashes, this makes all reads from conditions memcpy()s. The issue is that a 32 bit read straddling a VRAM mirror will crash.
Also fix a long standing bug that makes the disasm confused when you return to an idle thread.
-[Unknown]