Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gods Eater Burst and God Eater 2 brightness issue in hardware render #17033

Open
5 tasks done
Deka710 opened this issue Mar 1, 2023 · 14 comments
Open
5 tasks done

Gods Eater Burst and God Eater 2 brightness issue in hardware render #17033

Deka710 opened this issue Mar 1, 2023 · 14 comments
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@Deka710
Copy link

Deka710 commented Mar 1, 2023

Game or games this happens in

ULUS10563 - Gods Eater Burst
NPJH50832 - God Eater 2

What area of the game

.

What happens

the game brightness looks too bright in hardware render
edit: God Eater 2 also have the same issue
Screenshot_2023-03-01-06-43-29-509_org ppsspp ppssppgold

What should happen

it should not looks that bright like in sofware render below:
Screenshot_2023-03-01-06-45-32-032_org ppsspp ppssppgold

GE frame capture

ULUS10563.zip

Platform

Android

Mobile phone model or graphics card

Xiaomi Poco F3

PPSSPP version affected

1.14.4

Last working version

.

Graphics backend (3D API)

Vulkan

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try changing graphics settings to determine if one causes the glitch (especially speed hacks or enhancements/replacements.)
  • Include logs or screenshots of issue.
@ghost
Copy link

ghost commented Mar 1, 2023

Duplicate of long standing issue #5562 #2678 but it was close (I don't why).

Related issue #13950

@Deka710
Copy link
Author

Deka710 commented Mar 1, 2023

i think its different issue

@ghost
Copy link

ghost commented Mar 1, 2023

Did you try lower resolution for effects doesn't help reduce the excessive bloom?

@Deka710
Copy link
Author

Deka710 commented Mar 1, 2023

Did you try lower resolution for effects doesn't help reduce the excessive bloom?

i tried it but does nothing

@LunaMoo
Copy link
Collaborator

LunaMoo commented Mar 1, 2023

I don't think software renderer looks as it should in here, maps in GE are lighter as far as I recall and your screenshot looks like bloom wasn't working in software at all.
Not saying bloom looks great in those games, on PSP it's pretty poor and emulated requires hack or native res to even display correctly(without it get's sharp edges and ghosting issues), but it should be there and the in-game is generally all washed with that bloom.

The old issue was fixed, back then the bloom was much stronger than it should be resulting in not seeing anything in some places that should simply be as they are now - light and washed out.

@LunaMoo
Copy link
Collaborator

LunaMoo commented Mar 1, 2023

Here's a video of the same night map you made screenshots of:
https://www.youtube.com/watch?v=vbwjDk8Enrk
It's from GER - remaster version - which obviously looks better, but generally lightning looks correct in hardware renderer as long as native resolution or "lower resolution for effects" hack is used.

Edit: in short, it is a valid issue, but it's about bloom not working in software renderer(at least on your hardware), not about hardware renderer being wrong.

@ghost
Copy link

ghost commented Mar 1, 2023

Try color correction shader just reduce the brightness 😉

Screenshot_20230302_073408_2f85358b2198d26f8aca533d68bee793

The result
Screenshot_20230302_073402_2f85358b2198d26f8aca533d68bee793

@Deka710
Copy link
Author

Deka710 commented Mar 1, 2023

Here's a video of the same night map you made screenshots of: https://www.youtube.com/watch?v=vbwjDk8Enrk It's from GER - remaster version - which obviously looks better, but generally lightning looks correct in hardware renderer as long as native resolution or "lower resolution for effects" hack is used.

Edit: in short, it is a valid issue, but it's about bloom not working in software renderer(at least on your hardware), not about hardware renderer being wrong.

Screenshot_2023-03-02-06-33-37-562_org ppsspp ppssppgold
it look like this in software,idk which bloom are you talking about but it seems works here

@ghost ghost mentioned this issue Mar 1, 2023
@LunaMoo
Copy link
Collaborator

LunaMoo commented Mar 1, 2023

The video I posted was about during in-game map which you reported(it should NOT be as dark as in your "software" screenshot), not about hub.
Through that screenshot of the hub kind of looks weirdly dark as well, this game was when displaying correctly should be much more washed out(again, not saying it looks great, it's just how it should look) and your software screenshots looks like having too much contrast.

@Deka710
Copy link
Author

Deka710 commented Mar 2, 2023

The video I posted was about during in-game map which you reported(it should NOT be as dark as in your "software" screenshot), not about hub. Through that screenshot of the hub kind of looks weirdly dark as well, this game was when displaying correctly should be much more washed out(again, not saying it looks great, it's just how it should look) and your software screenshots looks like having too much contrast.

ok but yeah it looks worse when displayed correctly too bright imo, on real psp looks better

@sum2012 sum2012 added the GE emulation Backend-independent GPU issues label Mar 3, 2023
@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Apr 2, 2023

Hm, here's that framedump run on a PSP, with the bloom playback modified to ensure it is using the drawing (it was already, though):
#17033_ULUS10563_geb_softgpu_bloom_edit

Here's before the bloom, just for reference (again, from real PSP render):
#17033_ULUS10563_geb_softgpu_bloom_edit_prebloom

Software looks like this:
#17033_ULUS10563_geb_softgpu_bloom_software

The most notable difference is the rain actually (note for investigation: rain seems like it's drawn around 3778/3945.)

Vulkan renders like this:
#17033_ULUS10563_geb_softgpu_bloom_vulkan

So then the question is this: is the playback somehow wrong or is hardware wrong after all? Well, my best option is to take a screenshot from within the game, while it's running. So here's one:
#17033_ULUS10563_geb_runtime

And then I captured a framedump from PPSSPP at that same location and ran that on a PSP as well, which seems to match:
#17033_ULUS10563_geb_runtime_close

Vulkan however is clearly much brighter:
#17033_ULUS10563_geb_runtime_close_vulkan

While software looks okay, but is slightly off:
#17033_ULUS10563_geb_runtime_close_software

So, not sure why (maybe higher bitdepth?) but I think the bloom in hardware is what's wrong.

-[Unknown]

@hrydgard hrydgard added this to the Future-Prio milestone Apr 2, 2023
@Deka710 Deka710 changed the title Gods Eater Burst brightness issue in hardware render Gods Eater Burst and God Eater 2 brightness issue in hardware render Apr 12, 2023
@IrfanH495
Copy link

I also experienced it
samsung m20
vulkan
Screenshot_20240308-144707_PPSSPP
software rendering
Screenshot_20240308-144721_PPSSPP
NPJH50832_0002.zip

@IrfanH495
Copy link

i just tried playing it seems like god eater 2 is better than god eater burst playing in the first place and looking for a place that has bright light
Screenshot_20240315-045234_PPSSPP

@IrfanH495
Copy link

just too bright for a moment, for characters who have white skin.
especially Alisa, she experiences it very often.
god eater burst.

27_720p.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

6 participants