-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tilt improvements: Add visualizer, better defaults #16889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
Input/Controller
Input and controller issues
User Interface
PPSSPP's own user interface / UX
labels
Feb 1, 2023
There might be some minor issues with the translations, for example in Italian one:
"To Calibrate" will ask to press "Calibra", but the button will actually be called "Calibra il D-Pad". Same with few other languages. Probably it's quite confusing it's referencing D-Pad here at all :/ |
It's not supposed to reference the D-Pad at all, dunno where that came from. I'll fix it. |
Narugakuruga
reviewed
Feb 1, 2023
Narugakuruga
reviewed
Feb 1, 2023
Narugakuruga
reviewed
Feb 1, 2023
Narugakuruga
reviewed
Feb 1, 2023
Narugakuruga
reviewed
Feb 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #16881
Turns out it was nearly impossible to understand how tilt controls worked without a visualizer, so I added one.
And it was revealed that my understanding was wrong too (I didn't write the code originally), especially around calibration.
I'll followup with a change that will make it work better held at an angle. This will remove the Base Position setting and replace with just calibration.
Anyway, here's the first improvement to the UI, which already makes it much easier to configure: