Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchpad scrolling is not smooth #16600

Open
hrydgard opened this issue Dec 16, 2022 · 11 comments
Open

Touchpad scrolling is not smooth #16600

hrydgard opened this issue Dec 16, 2022 · 11 comments
Labels
User Interface PPSSPP's own user interface / UX
Milestone

Comments

@hrydgard
Copy link
Owner

An increasing amount of PC laptops are sold with great touchpads that support smooth two-finger scrolling as well as Apple does. Unfortunately we only support the old school mousewheel up/down events, which feels very jerky and uncontrollable on these. So this needs fixing on Windows.

Additionally, I think SDL now has support for smooth scrolling so we should look into supporting this on Mac and Linux as well.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Dec 16, 2022
@hrydgard hrydgard added this to the v1.15.0 milestone Dec 16, 2022
@hrydgard
Copy link
Owner Author

hrydgard commented Jan 1, 2023

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 11, 2023

This has been fixed on Windows.

On Mac/Linux, according to Genymobile/scrcpy#3363, we can use preciseX and preciseY in SDL_MouseWheelEvent.

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 11, 2023

Ok, I'm stuck, on Mac at least. preciseX/Y requires SDL 2.0.18, but even with "brew upgrade" and all that, my SDL headers seem stuck somehow, or we specify the minimum SDL version somewhere I can't find.

I get this log line, so it does look like the latest version is actually installed:

Info: We compiled against SDL version 2.0.16, but we are linking against SDL version 2.26.3., be aware that this can lead to unexpected behaviors

@hrydgard hrydgard modified the milestones: v1.15.0, v1.16.0 Feb 11, 2023
@unknownbrackets
Copy link
Collaborator

Isn't there a bundled SDL on macOS? This thing?

https://github.com/hrydgard/ppsspp-mac-sdl

-[Unknown]

@hrydgard
Copy link
Owner Author

Oh darn, I completely forgot we had that.

@hrydgard
Copy link
Owner Author

OK so I copied a new SDL2.framework into that submodule locally, but it doesn't build with it:

In file included from /Users/hrydg/ppsspp/SDL/SDLMain.mm:8:
/Users/hrydg/ppsspp/SDL/macOS/SDL2.framework/Headers/SDL.h:32:10: fatal error: 'SDL2/SDL_main.h' file not found
#include <SDL2/SDL_main.h>

But it's strange, the framework seems to be organized pretty much the same as the old one, so I just don't get it..

@unknownbrackets
Copy link
Collaborator

Hm, https://github.com/hrydgard/ppsspp-mac-sdl/blob/main/SDL2.framework/Versions/A/Headers/SDL.h doesn't currently contain "SDL2/". Maybe missing some new files that weren't committed? Or I don't really know how include paths work with these frameworks.

-[Unknown]

@hrydgard
Copy link
Owner Author

It's exactly the same in both the old and the new framework. Maybe there's some hidden symlink or something, I don't know either.

@hrydgard
Copy link
Owner Author

This was solved a while ago, though there are still some DPI issues on linux. Closing.

@tolotrasamuel
Copy link

This is not fixed on MAC. Please reopen this issue.
Two finger scroll not smooth on Mac

@hrydgard hrydgard reopened this Sep 9, 2024
@hrydgard
Copy link
Owner Author

hrydgard commented Sep 9, 2024

For me, it is pretty smooth on Mac actually, although could be silkier I guess. For you, is it scrolling in steps?

@hrydgard hrydgard modified the milestones: v1.16.0, v1.19.0 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

No branches or pull requests

3 participants