Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tactics Ogre - do something about the slow GPU readbacks #16537

Open
hrydgard opened this issue Dec 10, 2022 · 3 comments
Open

Tactics Ogre - do something about the slow GPU readbacks #16537

hrydgard opened this issue Dec 10, 2022 · 3 comments
Labels
GPU readback Issue related to readbacks from the GPU to CPU Performance Unexpected slow performance issues
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented Dec 10, 2022

As mentioned in #10171 (comment) , the game appears to do an unnecessary 48x48 readback every frame. These are very, very expensive, especially on mobile, and if it indeed is something like a leftover debugging feature, I think a compat hack might be in order.

That's because to run this game a bit more smoothly, many people are going to resort to "Skip GPU readbacks", which may cause issues in other games, leading to bug reports etc. If the readbacks are simply not needed, we probably should take them out. Would not do this for other kinds of unnecessary draws, but readbacks are special.

The game does a lot of other readbacks though so this would only partially solve the problem, not actually sure if the whole game plays ok if you disable them all?

Was reminded of this by #16534 .

@hrydgard hrydgard added the Performance Unexpected slow performance issues label Dec 10, 2022
@nassau-tk
Copy link
Contributor

Android Galaxy S20
Snapdragon865 / RAM12GB
If turn On [Skip GPU Readback] then "Tactics Ogre" will work good FPS but the graphics will broke.
https://user-images.githubusercontent.com/48179091/206950067-daf4f184-a591-4166-b37b-aca86be95ff7.mp4

And, If turn Off [Skip GPU Readback] then "Tactics Ogre" will work bad FPS but the graphics will correctly.
*about 40~55/60fps

On Windows PC.... It will not need [Skip GPU Readback].
Good FPS & Good graphics.
Ryzen7 3700X & Geforce RTX3060

Ge dump here...
ULJM05753_0001.zip

@ghost
Copy link

ghost commented Dec 12, 2022

#OT
There's also a performance regression in Dante's Inferno speed/fps down by 6.

VK/OGL
v1.13.2-2456
Screenshot_20221212_124709_2f85358b2198d26f8aca533d68bee793
v1.13.2
Screenshot_20221212_124410_74c288e31530b9e5d0ca749a600f3e41
ULUS10469.ppdmp.zip

@hrydgard
Copy link
Owner Author

That's interesting and I'll take a look, but it doesn't have anything to do with the Tactics Ogre problem.

@ghost ghost mentioned this issue Feb 3, 2023
7 tasks
@hrydgard hrydgard added the GPU readback Issue related to readbacks from the GPU to CPU label Feb 16, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Feb 16, 2023
@hrydgard hrydgard modified the milestones: v1.16.0, v1.17.0 Jul 21, 2023
@hrydgard hrydgard modified the milestones: v1.17.0, Future-Prio Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPU readback Issue related to readbacks from the GPU to CPU Performance Unexpected slow performance issues
Projects
None yet
Development

No branches or pull requests

2 participants