Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key bind to hotswap internal screen rotation #15494

Merged
merged 2 commits into from
Apr 23, 2022

Conversation

iota97
Copy link
Contributor

@iota97 iota97 commented Apr 23, 2022

As requested on Discord by Azureal:

Screenshot_2022-04-23_08-53-41

@hrydgard
Copy link
Owner

Hm. Maybe we should consider a single toggle key bind instead? Although four isn't too bad I suppose. Mainly concerned about the number of strings to translate, as usual...

@hrydgard hrydgard added this to the v1.13.0 milestone Apr 23, 2022
@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Apr 23, 2022
@iota97
Copy link
Contributor Author

iota97 commented Apr 23, 2022

A single hotkey is not enough to take care of both 90 and 270 degree rotation. I can do 2 if you prefer tho' :)

Another option might be having 2 button, one to rotare 90 degree left and the other right. This will handle also 180 rotation with 2 key

@hrydgard
Copy link
Owner

Why not, you could just have the same key toggle through the four directions :) And binding one key is easier than binding two (I think most people wouldn't use all four) plus you don't even have to think if you want portrait or reverse portrait for example, you just hit the key until it looks right.

Although, if four separate keybindings really is useful, I'm fine with it.

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Apr 23, 2022

Hm. Cycling through four sounds potentially annoying if it's when the game goes to a certain screen and you want to flip back and forth.

It'd be even more translations, but I suppose the other option would be a single bind to toggle orientation + a per game setting for what the alternate orientation is. Similar to alternate speed, etc. But personally I think all four is probably fine...

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Apr 23, 2022

Hm yeah, I didn't consider the case of games that often switch rotations, figured it would mostly be per-session.

Eh, let's go with all four.

@unknownbrackets
Copy link
Collaborator

If I understood Discord, that was this case - I haven't played .hack//LINK, but sounded like it has a message center that expects you to rotate your PSP to read it.

-[Unknown]

@hrydgard hrydgard merged commit a8ddde5 into hrydgard:master Apr 23, 2022
@iota97 iota97 deleted the InternalRotationBind branch April 24, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants