Vulkan: Specify Vulkan version, fix mip level generation calculation #15211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -291,6 +291,8 @@ class VulkanRenderManager { | |||
|
|
|||
| void SetScissor(VkRect2D rc) { | |||
| _dbg_assert_(curRenderStep_ && curRenderStep_->stepType == VKRStepType::RENDER); | |||
| _dbg_assert_((int)rc.offset.x >= 0); | |||
There was a problem hiding this comment.
I assume one could use the display layout editor to make these values negative (i.e. CenterDisplayOutputRect)?
-[Unknown]
There was a problem hiding this comment.
Hm, yeah, good point - though it technically is the callers responsibility to do the clipping, maybe it indeed makes sense to tolerate bad dimensions here and adjust automatically instead of asserting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation errors caught some erroneous mipmap counts, due to computing the number of mipmaps to generate at the wrong place in the function.
Also, if Vulkan 1.1 or 1.2 is available, let's opt in to them. We don't really rely on anything from the new numbered versions, but at this point I think 1.1 is the most well tested path in drivers, in case there's a difference.