Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial search to savedata manager #14237

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

unknownbrackets
Copy link
Collaborator

@unknownbrackets unknownbrackets commented Feb 28, 2021

This adds a button to type a term, and does a simple search for that term among the list.

Some improvements that would still be good, but don't block usefulness:

  • Better lowercasing for search (Unicode aware), maybe even romanji match for the common case of Japanese names.
  • Inline search field entry on desktop / separate keyboard devices, and filter as you type.
  • Some sort of throbber as it searches (currently async, but no indication of progress.)
  • Maybe clearer indication to clear your search (considered swapping "Search" to "Clear Search"...)

Thought this might be an obvious application of #14202, but of course the delayed loading of ginfo made it more complex. That's actually a problem if we expose to accessibility anyway, since Draw is not really relevant...

Still, I think this is a very useful place for UI search. Other candidates:

  • Recent list (not sure where to put it...)
  • Other game lists, including remote browsing.
  • System info (namely extensions lists.)

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.12.0 milestone Feb 28, 2021
@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Feb 28, 2021
@hrydgard
Copy link
Owner

hrydgard commented Mar 8, 2021

Finally got around to try this. The Search button is a little too off in the corner, not sure where to best put it though. Code looks good, merging.

@hrydgard hrydgard merged commit 977b48f into hrydgard:master Mar 8, 2021
@unknownbrackets unknownbrackets deleted the ui-search branch March 8, 2021 23:41
@unknownbrackets
Copy link
Collaborator Author

unknownbrackets commented Mar 8, 2021

I suppose I could do what all the cool kids do and hide it and the sorting options in a tiny button with three dots inside it.

Though I'm being slightly sarcastic, it might in fact be easier to notice for people that way.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants