Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPSSPP Crashes when trying to load Digimon Adventure PSP NPJH-50686 Cutscene videos #13371

Closed
LPatamon opened this issue Sep 2, 2020 · 8 comments
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@LPatamon
Copy link

LPatamon commented Sep 2, 2020

What happens?

When I go to the video library on the game and try to watch any of the cut scene videos, the emulator crashes, this also happens when advancing on the game and a get to a moment in which a cutscene video should appear. Here is a video of the issue.

https://www.youtube.com/watch?v=SPBRZcMMj-I

What should happen?

The videos should play correctly as they used to do so on previous versions of PPSSPP

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

3Ghz Core i5-3330 (Quad Core), 4GB Ram and 2GB GDDR5 Gigabyte Nvidia GT1030 on Windows 7 Ultimate 32 bits Desktop PC.

PPSSPP Version: v1.10.3-547-gd8a5c710f

Notes.

This crashing started on the builds after v1.10.3-515-gcb3ed8f4a build, since v1.10.3-515-gcb3ed8f4a was the last one where the videos worked, since the next build was v1.10.3-518-g81159770d (but only for Android and Windows 64 bits, while the next build for Windows 32bits was v1.10.3-520-g594564298, the issue making the emulator to crash when trying to play the videos, has to be either on the 3 builds that had no download link or starting on build v1.10.3-518-g81159770d.

This issue just made the game impossible to progress since the crash happens even when you're advancing through the story. I tested it starting a new game and when a cutscene video was to play, the emulator crashed, so no way to advance in the game unless you use a build where the videos work.

Even so, on recent builds where the videos play correctly, the emulator still crashed randomly if you stopped the emulation while the video was playing, thing that didn't happened before. I'm still trying to pinpoint on which build the random crash started since from build v1.10.3-387-g6ca01d588 (which was the one I had before I updated to build v1.10.3-515-gcb3ed8f4a which was the one where I noticed the random crash if I closed the emulation while the video was playing) to build v1.10.3-426-g3c8ca6ad8 the videos worked without any issue, I could stop the emulation with the video playing and no crash at all.

I'll keep searching where the random crash when stopping the emulation while a cutscene video is playing started, I'll update this thread as soon I get some information.

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Sep 2, 2020
@hrydgard hrydgard added this to the v1.11.0 milestone Sep 2, 2020
@hrydgard
Copy link
Owner

hrydgard commented Sep 2, 2020

Thanks for reporting. We've made some rather drastic changes to framebuffer management lately so some fallout is to be expected and reporting is how it gets fixed :)

Will investigate.

@LPatamon
Copy link
Author

LPatamon commented Sep 2, 2020

Thanks for reporting. We've made some rather drastic changes to framebuffer management lately so some fallout is to be expected and reporting is how it gets fixed :)

Will investigate.

No problem. Guess those changes to framebuffer management didn't get along with a few games like in this case with Digimon Adventure PSP.

Ah well. Thanks for the reply :)

@LPatamon
Copy link
Author

LPatamon commented Sep 2, 2020

Okay. I managed to pinpoint the last build that had no crashes when stopping the emulation while the video was playing on Digimon Adventure PSP.

The last good build in which there was no issues with the cutscene videos was v1.10.3-470-ge8779fdc8. After that there are two versions that had no build to download on the buildbot which are v1.10.3-471-g506a86300 and v1.10.3-472-g26ba65f38, after that the next build that has download links is v1.10.3-473-gbf18817fe and is on this build where the crashes when stopping the emulation while a cutscene video is played started.

v1.10.3-473-gbf18817fe has the following comment on the buildbot: Merge: e8779fd 26ba65f Merge pull request #13319 from hrydgard/state-cleanup-cleanup State cleanup cleanup

Yes. I'm the type of guy who does a good investigation so my report is as complete as possible XD

Hope it helps.

@LPatamon
Copy link
Author

LPatamon commented Sep 3, 2020

Here is a video of the crash when you stop the emulation while a cutscene video of Digimon Adventure PSP is playing:

https://www.youtube.com/watch?v=jhkbYAytpXY

I added the normal behavior the emulator should have by using a version where there was no crashes at all.

@hrydgard
Copy link
Owner

hrydgard commented Sep 4, 2020

Fixed now, thanks for reporting!

@LPatamon
Copy link
Author

LPatamon commented Sep 4, 2020

Opened a new issue. There was a side effect on the fix. it partially undid another fix you did for this same game.

@hrydgard
Copy link
Owner

hrydgard commented Sep 4, 2020

I think it was the change that started crashing that broke it, rather than the fix.

@LPatamon
Copy link
Author

LPatamon commented Sep 4, 2020

I think it was the change that started crashing that broke it, rather than the fix.

Mmmh... yeah that's possible indeed. Framebuffer no doubt is such a very delicate thing to work with. any modification can lead to errors with some games, since it is impossible to know what will affect and what not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

2 participants