Riviera: The promise land (ULES00818) crashing randomly when pressing unthrottle continuesly

[ghost]

What happens?

The game is crashing when pressing unthrottle for about 1 - 2 minutes of the game

What should happen?

Not crashing when pressing unthrottle

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Android 6.0.1
Mali-450 GPU
OpenGL ES 2.0
PPSSPP v1.9.3-932

Catlog Crash log

05-24 13:06:21.511 F/DEBUG   (341): pid: 9648, tid: 9666, name: Emu  >>> org.ppsspp.ppsspp <<<
05-24 13:06:21.550 F/DEBUG   (341):     #00 pc 00437916  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN18TextureCacheCommon8LoadClutEjj+317)
05-24 13:06:21.550 F/DEBUG   (341):     #01 pc 0044e6c5  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN9GPUCommon15ReapplyGfxStateEv+272)
05-24 13:06:21.550 F/DEBUG   (341):     #02 pc 0044cbbb  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN9GPUCommon14BeginHostFrameEv+10)
05-24 13:06:21.550 F/DEBUG   (341):     #03 pc 003d73ad  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN8GPU_GLES14BeginHostFrameEv+6)
05-24 13:06:21.550 F/DEBUG   (341):     #04 pc 004b17f3  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN9EmuScreen6renderEv+226)
05-24 13:06:21.550 F/DEBUG   (341):     #05 pc 0055cba1  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN13ScreenManager6renderEv+84)
05-24 13:06:21.551 F/DEBUG   (341):     #06 pc 004a8aaf  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_Z12NativeRenderP15GraphicsContext+810)
05-24 13:06:21.551 F/DEBUG   (341):     #07 pc 004a28a3  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_Z20UpdateRunLoopAndroidP7_JNIEnv+22)
05-24 13:06:21.551 F/DEBUG   (341):     #08 pc 004a41c5  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so
05-24 13:06:21.551 F/DEBUG   (341):     #09 pc 002b03d5  /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZNSt6__ndk114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFvvEEEEEEPvSA_+24)
05-24 13:06:22.250 W/ActivityManager(630):   Force finishing activity org.ppsspp.ppsspp/.PpssppActivity
05-24 13:06:22.416 I/WindowState(630): WIN DEATH: Window{5095673 u0 org.ppsspp.ppsspp/org.ppsspp.ppsspp.PpssppActivity}
05-24 13:06:22.416 W/WindowManager(630): Force-removing child win Window{c62f97 u0 SurfaceView} from container Window{5095673 u0 org.ppsspp.ppsspp/org.ppsspp.ppsspp.PpssppActivity}
05-24 13:06:22.450 I/ActivityManager(630): Process org.ppsspp.ppsspp (pid 9648) has died

[sum2012]

I test v1.9.3-924-gbff3c15d6 crash
v1.9.3-941-gf7270733a not crash

@Gamemulatorer can you confirm again in v1.9.3-941-gf7270733a ?

[ghost]

@unknownbrackets @sum2012 Confirmed I cannot reproduce this issue anymore I play for 3 times and it doesn't crash like before when unthrottle is pressing.

I'm using the latest git build maybe this was fixed by #12962

[unknownbrackets]

Well, it's still weird that it crashed with this trace, but I was thinking - maybe this is something outside a frame begin/end or something, and an inlined function?

Either way, glad that change fixed this crash.

-[Unknown]

[hrydgard]

Followed up that one with f0550a6 , in case we ever do something substantial with TEXSYNC/TEXFLUSH.