Correct mp3 looping, frame num, and sum decoded #12005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might matter if some game is checking the result.
This might fix games failing to play mp3s correctly.
It shouldn't consider both channels of stereo. This could've been causing some games to think they were playing audio at an incorrect speed.
And only on loop, not when getting add info (which clearly doesn't loop, from tests.)
If the offset points to an ID3 tag or the middle of a frame, that's fine - it should just search forward to the next sync. FFmpeg just returns a decode error, so we do this first.
|
FWIW, I have more mp3 changes - I just again want them in a separate PR (and they depend on these changes.) The reset and reset by frame funcs are pretty wrong, and I'll be fixing the broken ID3 handling. -[Unknown] |
|
Alright, cool. This seems all fine - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
Note: per More mp3 tests pspautotests#199, vbr Xing/Info/etc. isn't handled.
All based on tests in hrydgard/pspautotests#199. Note: some of the tests don't pass, but only due to sceMp3LowLevelInit rescheduling issues. I still wanted to keep that in the tests to verify error behavior with low level streams.
-[Unknown]