Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naruto Ultimate Ninja Impact - Hachibi shading wrong #11568

Open
unknownbrackets opened this issue Nov 18, 2018 · 2 comments
Open

Naruto Ultimate Ninja Impact - Hachibi shading wrong #11568

unknownbrackets opened this issue Nov 18, 2018 · 2 comments
Labels
GE emulation Backend-independent GPU issues Mipmaps Mipmapping related issues
Milestone

Comments

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Nov 18, 2018

See related issue #4155.

GE dump: ULUS10582_#4155_naruto_white_enemy.zip

The first pass dark shading uses slope mip mapping + shade mapping from 0x08940480.

Correct result (same frame using dump):
ulus10582_ 4155_naruto_white_enemy

With #11567, we're getting most of this right, but it's too harsh. Even the white may be too harsh (not sure):
better shade mapping

Forcing the bias from slope + 0.0625 to const 1.0 gives us the smoother shading expected:
naruto_shading

-[Unknown]

@unknownbrackets
Copy link
Collaborator Author

Updated the correct result to be exactly the same frame. The white is off somewhat. It almost looks closer if I use (0, 0, 0.85) or something, but not quite.

-[Unknown]

@ghost
Copy link

ghost commented Jun 11, 2020

Correct result (same frame using dump):
ulus10582_ 4155_naruto_white_enemy

PPSSPP v1.9.3-1015
Screenshot_20200611-135811

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Jun 11, 2020
@hrydgard hrydgard added this to the v1.11.0 milestone Jun 11, 2020
@hrydgard hrydgard modified the milestones: v1.11.0, v1.12.0 Nov 11, 2020
@hrydgard hrydgard added the Mipmaps Mipmapping related issues label Nov 11, 2020
@hrydgard hrydgard modified the milestones: v1.12.0, Future Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues Mipmaps Mipmapping related issues
Projects
None yet
Development

No branches or pull requests

2 participants