Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vulkan] Resizing the window freezes the UI (SDL, Linux) #11014

Closed
vnctdj opened this issue May 7, 2018 · 2 comments · Fixed by #11451
Closed

[Vulkan] Resizing the window freezes the UI (SDL, Linux) #11014

vnctdj opened this issue May 7, 2018 · 2 comments · Fixed by #11451
Labels
Platform-specific (Linux/POSIX) SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan
Milestone
v1.8.0

Comments

@vnctdj
Copy link
Contributor

vnctdj commented May 7, 2018 •
edited
Loading

Resizing the window freezes the UI when using Vulkan (it stops drawing anything), however the process doesn't seem to hang.

There is no problem with OpenGL.

OS: Debian GNU/Linux testing (buster) x86_64
Kernel: 4.16.0-1-amd64
CPU: Intel i7-6700HQ (8) @ 3.500GHz
GPU: NVIDIA GeForce GTX 960M
PPSSPP: v1.5.4-971-g97546d30f

It may matter that I use i3 as window manager.
@vnctdj vnctdj mentioned this issue May 7, 2018
Closed
@vnctdj vnctdj changed the title [Vulkan] Resizing the window freezes PPSSPP [Vulkan] Resizing the window freezes the UI May 7, 2018
@hrydgard hrydgard added this to the v1.7.0 milestone May 7, 2018
@hrydgard
Copy link
Owner

hrydgard commented Oct 6, 2018 •
edited
Loading

So what happens is that we get back VK_ERROR_OUT_OF_DATE_KHR when trying to acquire an image, every single frame, and we never try to recreate the swapchain. Something is missing - Resize isn't implemented properly in SDLVulkanGraphicsContext. Guess I forgot to finish that up. Will get to it soon

@unknownbrackets unknownbrackets added the SDL2 Issue on SDL (or Qt in SDL code) but not all ports. label Oct 6, 2018
@unknownbrackets
Copy link
Collaborator

Yeah, it's just commented out:
https://github.com/hrydgard/ppsspp/blob/master/SDL/SDLVulkanGraphicsContext.h#L28-L37

-[Unknown]

@hrydgard hrydgard mentioned this issue Oct 7, 2018
Merged
@hrydgard hrydgard modified the milestones: v1.7.0, v1.8.0 Oct 20, 2018
@orbea orbea mentioned this issue Dec 3, 2018
Closed
@hrydgard hrydgard changed the title [Vulkan] Resizing the window freezes the UI [Vulkan] Resizing the window freezes the UI (SDL, Linux) Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform-specific (Linux/POSIX) SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

SDL/Vulkan window resize improvements hrydgard/ppsspp
3 participants
@hrydgard @unknownbrackets @vnctdj