Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the game's icon in Android and Windows shortcuts #10885

Open
unknownbrackets opened this issue Apr 7, 2018 · 3 comments
Open

Use the game's icon in Android and Windows shortcuts #10885

unknownbrackets opened this issue Apr 7, 2018 · 3 comments

Comments

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Apr 7, 2018

See #10841.

Games have icons, and custom can be set with EXTRA_SHORTCUT_ICON/setIcon.

EDIT by hrydgard: And on Windows, you can use psl->SetIconLocation(..) - but you can't embed the icon in the .link as far as I know, so we need to store generated .ico files in our directory.

The only trick is that the icon isn't quite the right aspect ratio, although the Vita has the same problem and its UI simply centers the icon and hopes for the best. Maybe that's fine?

-[Unknown]

@AkiraJkr
Copy link

AkiraJkr commented Apr 7, 2018

Perhaps find a way to implement a shortcut creation feature for Windows too? That would be neat so people don't have to fully rely on custom icons.

image

@hrydgard hrydgard added this to the Future milestone Nov 8, 2018
@ghost ghost mentioned this issue Dec 12, 2022
2 tasks
@ghost ghost mentioned this issue Jan 12, 2023
@hrydgard hrydgard changed the title Use the game's icon in Android shortcuts Use the game's icon in Android and Windows shortcuts Aug 18, 2023
@hrydgard hrydgard modified the milestones: Future, v1.17.0 Aug 18, 2023
@hrydgard hrydgard modified the milestones: v1.17.0, v1.18.0 Dec 7, 2023
hrydgard added a commit that referenced this issue May 12, 2024
… PPSSPP's.

Since on Windows, shortcuts can't embed icons, we first save the game's
icon .png as an .ico in the SAVESTATE folder (there might be a better
place, but it also doesn't seem worth it to create a new folder for
this).

Part of #10885 (Android functionality still missing, for example).
@hrydgard
Copy link
Owner

@AkiraJkr #19138 implements this for Windows, finally :)

@hrydgard
Copy link
Owner

hrydgard commented May 13, 2024

#19139 implements it for Android, but with the limitation that PPSSPP needs to be running in the background while you create the widget (otherwise you'll get the PPSSPP icon like before). I'll try to lift that restriction in the future, but this is enough progress for 1.18.

@hrydgard hrydgard modified the milestones: v1.18.0, v1.19.0 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants