Request a core profile in OpenGL (after 1.5.0) #10113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
force-pushed
the
core-context
branch
from
4672637 to
556cc15
Compare
|
Agreed, will merge after the inevitable 1.5.1 :) |
mrcmunir
approved these changes
Nov 23, 2017
|
@unknownbrackets For your information my understanding is that a core profile is far preferred as far as mesa is concerned. :) |
|
A core profile is also nice because it makes RenderDoc happy :) |
This applies to all platforms, but falls back to a compat profile if core is not available.
Also, update to OpenGL 4.6.
unknownbrackets
force-pushed
the
core-context
branch
from
556cc15 to
c30e4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for SDL / Windows. Not sure about Qt, so not done there yet.
Thinking after 1.5.0, unless anyone feels otherwise. Fixes #8277 (allowing Mac OS X and some Linux using OpenGL 3.x+, improving various missing features / bugs.)
I also think it's worth doing on Windows, because for NVIDIA, core profiles seem to be faster. Not sure what bugs (or disappearances thereof?) might be found on AMD/Intel, though.
#8276 isn't fixed yet, but I don't think it really blocks this, because lines already have issues even in the compat profile (see for example #8509.)
-[Unknown]