Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to inject quality settings #22

Closed
gatisl opened this issue Oct 20, 2014 · 7 comments
Closed

Impossible to inject quality settings #22

gatisl opened this issue Oct 20, 2014 · 7 comments

Comments

@gatisl
Copy link

gatisl commented Oct 20, 2014

Default value of Imagine jpg quality is too low and there is no way to configure quality settings through HtImgModule.

Imagine accepts such options for save method
http://imagine.readthedocs.org/en/latest/usage/introduction.html#save-images

I suppose CacheManager::createCache() would be the right place to modify in order to achieve desired behaviour

    public function createCache($relativeName, $filter, ImageInterface $image, $formatOrImage = null)
    {
        $cachePath = $this->getCachePath($relativeName, $filter, $formatOrImage);
        //...
        //there must be way to inject $options through htimg configuration
        $image->save($cachePath, $options);
    }
@ojhaujjwal
Copy link
Member

Thanks for reporting this issue. I will take a look at it. 👍

@ojhaujjwal
Copy link
Member

Check if #23 fixes this issue for you and tell me there.

@gatisl
Copy link
Author

gatisl commented Oct 21, 2014

Yes, it helps. Thank you for fast response!

@ojhaujjwal
Copy link
Member

Okay. I will write tests and tag a new release soon. Can you come up with a PR with tests if you have time?

@ojhaujjwal
Copy link
Member

@gatisl 'No' is better than nothing for an answer.

@gatisl
Copy link
Author

gatisl commented Oct 24, 2014

Yes, I'm sorry, but I will not be able to find time for that

@ojhaujjwal
Copy link
Member

Fixed by #23 and new release 0.4.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants